* Haotian Li (lihaoti...@huawei.com) wrote: > In main func, strdup lo.source may fail. So check whether strdup > lo.source return NULL before using it. > > Signed-off-by: Haotian Li <lihaoti...@huawei.com> > Signed-off-by: Zhiqiang Liu <liuzhiqian...@huawei.com> > --- > tools/virtiofsd/passthrough_ll.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/virtiofsd/passthrough_ll.c > b/tools/virtiofsd/passthrough_ll.c > index 3e9bbc7a04..0c11134fb5 100644 > --- a/tools/virtiofsd/passthrough_ll.c > +++ b/tools/virtiofsd/passthrough_ll.c > @@ -3525,6 +3525,10 @@ int main(int argc, char *argv[]) > } > } else { > lo.source = strdup("/"); > + if (!lo.source) { > + fuse_log(FUSE_LOG_ERR, "failed to strdup source\n"); > + goto err_out1; > + } > } >
(It's interesting we use exit's in some places, goto's in others) Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > if (lo.xattrmap) { > -- > > _______________________________________________ > Virtio-fs mailing list > virtio...@redhat.com > https://www.redhat.com/mailman/listinfo/virtio-fs -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK