On Thu, Nov 19, 2020 at 11:41:05AM +0100, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > Useful function where we need to check for the qlit type before > > converting it to an actual QObject. > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > include/qapi/qmp/qlit.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h > > index f9e356d31e..acddb80831 100644 > > --- a/include/qapi/qmp/qlit.h > > +++ b/include/qapi/qmp/qlit.h > > @@ -59,4 +59,9 @@ bool qlit_equal_qobject(const QLitObject *lhs, const > > QObject *rhs); > > > > QObject *qobject_from_qlit(const QLitObject *qlit); > > > > +static inline QType qlit_type(const QLitObject *qlit) > > +{ > > + return qlit->type; > > +} > > + > > #endif /* QLIT_H */ > > Hiding qlit->type behind a function makes sense only when the structure > of QLitObject is an implementation secret. It don't think it is.
I thought all QLitObject fields were considered private. If they are not, I can happily get rid of that function. -- Eduardo