Patchew URL: https://patchew.org/QEMU/20201120130409.956956-1-...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201120130409.956956-1-...@redhat.com Subject: [PATCH for-5.2] Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()" === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201120073149.99079-1-pbonz...@redhat.com -> patchew/20201120073149.99079-1-pbonz...@redhat.com * [new tag] patchew/20201120130409.956956-1-...@redhat.com -> patchew/20201120130409.956956-1-...@redhat.com Switched to a new branch 'test' 1d9f6bd Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()" === OUTPUT BEGIN === ERROR: consider using qemu_strtoul in preference to strtoul #39: FILE: hw/core/qdev-properties-system.c:876: + val = strtoul(p, &e, 16); ERROR: consider using qemu_strtoul in preference to strtoul #48: FILE: hw/core/qdev-properties-system.c:883: + val = strtoul(p, &e, 16); ERROR: consider using qemu_strtoul in preference to strtoul #58: FILE: hw/core/qdev-properties-system.c:891: + val = strtoul(p, &e, 16); ERROR: consider using qemu_strtoul in preference to strtoul #70: FILE: hw/core/qdev-properties-system.c:902: + val = strtoul(p, &e, 10); total: 4 errors, 0 warnings, 56 lines checked Commit 1d9f6bd1223f (Revert "hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()") has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201120130409.956956-1-...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
