On 11/21/20 8:44 PM, Richard Henderson wrote:
> On 11/20/20 1:08 PM, Philippe Mathieu-Daudé wrote:
>> MSA means 'MIPS SIMD Architecture' and is defined as a Module by MIPS.
>> Rename msa_helper.c as mod-mips-msa_helper.c, merge other MSA helpers
>> from op_helper.c.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
>> ---
>> .../{msa_helper.c => mod-mips-msa_helper.c} | 392 +++++++++++++++++
>> target/mips/op_helper.c | 393 ------------------
>> target/mips/meson.build | 3 +-
>> 3 files changed, 394 insertions(+), 394 deletions(-)
>> rename target/mips/{msa_helper.c => mod-mips-msa_helper.c} (94%)
>
> Do we really need "mips" in the filename, given that it's implied by the
> directory?
Indeed we don't need it :)
>
> Maybe perform the rename and the op_helper.c move in different patches?
Sure, will do.
Regards,
Phil.
