On 11/30/20 9:52 PM, Klaus Jensen wrote: > On Nov 30 15:52, Philippe Mathieu-Daudé wrote: >> As IDE used to be, NVMe emulation is becoming an active >> subsystem. Move it into its own namespace. >> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> v2: Rebased after nvme-ns got merged in commit 8680d6e3646 >> --- >> meson.build | 1 + >> hw/{block/nvme.h => nvme/nvme-internal.h} | 4 +- >> hw/{block => nvme}/nvme-ns.h | 0 >> hw/{block/nvme.c => nvme/core.c} | 2 +- >> hw/{block => nvme}/nvme-ns.c | 0 >> MAINTAINERS | 2 +- >> hw/Kconfig | 1 + >> hw/block/Kconfig | 5 - >> hw/block/meson.build | 1 - >> hw/block/trace-events | 132 --------------------- >> hw/meson.build | 1 + >> hw/nvme/Kconfig | 4 + >> hw/nvme/meson.build | 1 + >> hw/nvme/trace-events | 133 ++++++++++++++++++++++ >> 14 files changed, 145 insertions(+), 142 deletions(-) >> rename hw/{block/nvme.h => nvme/nvme-internal.h} (98%) >> rename hw/{block => nvme}/nvme-ns.h (100%) >> rename hw/{block/nvme.c => nvme/core.c} (99%) >> rename hw/{block => nvme}/nvme-ns.c (100%) > > Would we want to consider renaming nvme-ns.c to namespace.c? And maybe > also follow up with consolidating nvme-ns.h into nvme-internal.h?
Yes, good idea! I'll respin. Thanks, Phil.