On Thu 03 Dec 2020 11:27:12 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Move bdrv_is_inserted() calls into callers. > > We are going to make bdrv_check_byte_request() a clean thing. > bdrv_is_inserted() is not about checking the request, it's about > checking the bs. So, it should be separate. > > With this patch we probably change error path for some failure > scenarios. But depending on the fact that querying too big request on > empty cdrom (or corrupted qcow2 node with no drv) will result in EIO > and not ENOMEDIUM would be very strange. More over, we are going to > move to 64bit requests, so larger requests will be allowed anyway. > > More over, keeping in mind that cdrom is the only driver that has > .bdrv_is_inserted() handler it's strange that we should care so much > about it in generic block layer, intuitively we should just do read and > write, and cdrom driver should return correct errors if it is not > inserted. But it's a work for another series. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
Reviewed-by: Alberto Garcia <be...@igalia.com> Berto
