On Wed, 2020-12-09 at 18:41 +0100, Alberto Garcia wrote:
> On Wed 09 Dec 2020 05:44:41 PM CET, Maxim Levitsky wrote:
> > @@ -3847,12 +3847,13 @@ static int coroutine_fn
> > qcow2_co_create_opts(BlockDriver *drv,
> >
> > /* Create the qcow2 image (format layer) */
> > ret = qcow2_co_create(create_options, errp);
> > +
> > +finish:
> > if (ret < 0) {
> > - goto finish;
> > + bdrv_co_delete_file_noerr(bs);
> > + bdrv_co_delete_file_noerr(data_bs);
> > }
> >
> > - ret = 0;
>
> Many/most functions in qcow2.c force ret to be 0 on success, we could
> also keep that here (although in practice I don't think that ret can be
> greater than 0 in this case, or that the caller would care).
I also noticed this when I was sending the patches, and I wasn't sure
if I want to keep that 'ret = 0' or not.
I will add it back.
Best regards,
Maxim Levitsky
>
> Either way,
>
> Reviewed-by: Alberto Garcia <be...@igalia.com>
>
> Berto
>
