Re: [PATCH 14/15] null-machine: do not create a default memdev

[Paolo Bonzini]

On 07/12/20 17:43, Igor Mammedov wrote:
      mc->default_ram_size = 0;
-    mc->default_ram_id = "ram";
+    mc->default_ram_id = NULL;
probably that will break:
  QEMU -m X -M none

No, it works.  "-m" is simply ignored, because the default memdev is 
created here:

    if (machine_class->default_ram_id && current_machine->ram_size &&
        numa_uses_legacy_mem() && !current_machine->ram_memdev_id) {
        create_default_memdev(current_machine, mem_path);
    }

and is thus skipped for -M none.

Paolo


maybe there is  a bug over there but
     "mc->default_ram_size = 0"
above, should result in
     current_machine->ram_size == 0
in case user hasn't provided "-m"
and hence memdev shouldn't be created