On Sun, 13 Dec 2020 at 17:22, Laurent Vivier <laur...@vivier.eu> wrote: > > Le 12/10/2020 à 11:47, Thomas Huth a écrit : > > On 25/08/2020 22.27, Roman Bolshakov wrote: > >> QEMU build fails with cryptic messages if make is too old: > >> > >> Makefile.ninja:2655: *** multiple target patterns. Stop. > >> > >> To avoid the confusion it's worth to fail the build right away and print > >> a friendly error message. > >> > >> +ifeq ($(filter undefine,$(value .FEATURES)),) > >> +$(error Unsupported Make version: $(MAKE_VERSION). \ > >> + Please use GNU Make 3.82 or above) > >> +endif > >> + > >> # Always point to the root of the build tree (needs GNU make). > >> BUILD_DIR=$(CURDIR) > > > > Reviewed-by: Thomas Huth <th...@redhat.com> > > > > > > Applied to my trivial-patches branch.
Commit 09e93326e448ab4 says that the switch to ninja from ninjatool removed the requirement for Make 3.82. Is this change still required? thanks -- PMM
