Kindly ping!
Hi all,
It's a bug, though it's trivial.
Could you review it and add your queues or add trivial queues?
Thanks,
Chen Qun
> -----Original Message-----
> From: Chenqun (kuhn)
> Sent: Friday, October 23, 2020 2:12 PM
> To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org
> Cc: Pannengyuan <pannengy...@huawei.com>; lviv...@redhat.com;
> Zhanghailiang <zhang.zhanghaili...@huawei.com>; ganqixin
> <ganqi...@huawei.com>; Euler Robot <euler.ro...@huawei.com>; Li Qiang
> <liq...@gmail.com>; Chenqun (kuhn) <kuhn.chen...@huawei.com>; Juan
> Quintela <quint...@redhat.com>; Dr. David Alan Gilbert
> <dgilb...@redhat.com>
> Subject: [PATCH RESEND v2 5/7] migration/colo: Plug memleaks in
> colo_process_incoming_thread
>
> From: Pan Nengyuan <pannengy...@huawei.com>
>
> 'local_err' forgot to free in colo_process_incoming_thread error path.
> Fix that.
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengy...@huawei.com>
> Reviewed-by: Li Qiang <liq...@gmail.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
> ---
> Cc: Hailiang Zhang <zhang.zhanghaili...@huawei.com>
> Cc: Juan Quintela <quint...@redhat.com>
> Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> ---
> migration/colo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/migration/colo.c b/migration/colo.c index 3f1d3dfd95..7cc5a37192
> 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -886,7 +886,6 @@ void *colo_process_incoming_thread(void *opaque)
> while (mis->state == MIGRATION_STATUS_COLO) {
> colo_wait_handle_message(mis, fb, bioc, &local_err);
> if (local_err) {
> - error_report_err(local_err);
> break;
> }
>
> @@ -922,6 +921,10 @@ out:
> qemu_fclose(fb);
> }
>
> + if (local_err) {
> + error_report_err(local_err);
> + }
> +
> /* Hope this not to be too long to loop here */
> qemu_sem_wait(&mis->colo_incoming_sem);
> qemu_sem_destroy(&mis->colo_incoming_sem);
> --
> 2.23.0
