Alex Bennée <alex.ben...@linaro.org> writes: > Hmm scratch that... it fails in a number of linux-user only builds with: > > /usr/bin/ld: > libqemu-aarch64_be-linux-user.fa.p/linux-user_aarch64_cpu_loop.c.o: in > function `cpu_loop': > /builds/stsquad/qemu/build/../linux-user/aarch64/cpu_loop.c:133: undefined > reference to `do_common_semihosting' > collect2: error: ld returned 1 exit status > [651/2871] Compiling C object > libqemu-alpha-linux-user.fa.p/target_alpha_translate.c.o > ninja: build stopped: subcommand failed.
I missed changing default-configs/targets/aarch64_be-linux-user.mak. > https://gitlab.com/stsquad/qemu/-/pipelines/229443833/failures Some of these were caused by a missing explicit cast to Int128, which is needed on hosts without compiler support for 128-bit ints. The rest app to have been the same problem with aarch64_be-linux-user. > On the next re-spin could you include Kito Cheng's patch for linux-user > support and also drop the version numbering from the commit titles so I > don't have to file them off again. Yup, all done. Thanks much for the review and for getting these tests run. I've rebased on current master and fixed the problems identified above. -- -keith
signature.asc
Description: PGP signature
