On Wednesday, 2020-12-16 at 12:29:40 +01, Kevin Wolf wrote: > Am 15.12.2020 um 20:01 hat David Edmondson geschrieben: >> When a call to fcntl(2) for the purpose of manipulating file locks >> fails, report the error returned by fcntl. >> >> Signed-off-by: David Edmondson <david.edmond...@oracle.com> > > Is appending "Resource temporarily unavailable" in the common case (a > file locked by another process) actually an improvement for the message > or more confusing? It would be good to mention the motivation for the > change in the commit message.
Distinguishing between the common case and others is at least a start when trying to figure out why it failed. We have potentially useful information to assist in diagnosis, why throw it away? In the case I encountered the failure appears to have been caused by SELinux misconfiguration. > Either way, this breaks some qemu-iotests cases whose reference output > needs to be updated. Will fix and send a v2. dme. -- We're deep in discussion, the party's on mute.
