On 30/11/2020 09.36, Gan Qixin wrote: > The category of the mc146818rtc device is not set, put it into the 'misc' > category. > > Signed-off-by: Gan Qixin <ganqi...@huawei.com> > --- > Cc: Michael S. Tsirkin <m...@redhat.com> > --- > hw/rtc/mc146818rtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c > index 7a38540cb9..39edca0996 100644 > --- a/hw/rtc/mc146818rtc.c > +++ b/hw/rtc/mc146818rtc.c > @@ -1039,6 +1039,7 @@ static void rtc_class_initfn(ObjectClass *klass, void > *data) > dc->vmsd = &vmstate_rtc; > isa->build_aml = rtc_build_aml; > device_class_set_props(dc, mc146818rtc_properties); > + set_bit(DEVICE_CATEGORY_MISC, dc->categories); > }
I wonder whether this device should be user_creatable at all (e.g. it uses a hard-coded IO port)... Anyway setting the category certainly does not hurt, thus: Reviewed-by: Thomas Huth <th...@redhat.com>
