Reviewed-by: Huacai Chen <chenhua...@kernel.org> On Fri, Jan 1, 2021 at 6:49 AM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Use the PCI_DEVFN() macro to replace the '0x28' magic value, > this way it is clearer we access PCI function #0 of slot #5. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/pci-host/bonito.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c > index efeba29011f..4c903d4f682 100644 > --- a/hw/pci-host/bonito.c > +++ b/hw/pci-host/bonito.c > @@ -626,7 +626,7 @@ static void bonito_pcihost_realize(DeviceState *dev, > Error **errp) > phb->bus = pci_register_root_bus(dev, "pci", > pci_bonito_set_irq, pci_bonito_map_irq, > dev, &bs->pci_mem, get_system_io(), > - 0x28, 32, TYPE_PCI_BUS); > + PCI_DEVFN(5, 0), 32, TYPE_PCI_BUS); > > for (size_t i = 0; i < 3; i++) { > char *name = g_strdup_printf("pci.lomem%zu", i); > -- > 2.26.2 >
- [PATCH 00/18] hw/pci-host/bonito: Remap PCI "... Philippe Mathieu-Daudé
- [PATCH 01/18] hw/pci-host/bonito: Remove unus... Philippe Mathieu-Daudé
- Re: [PATCH 01/18] hw/pci-host/bonito: Rem... Huacai Chen
- [PATCH 02/18] hw/pci-host/bonito: Display hex... Philippe Mathieu-Daudé
- [PATCH 03/18] hw/pci-host/bonito: Use PCI_DEV... Philippe Mathieu-Daudé
- Re: [PATCH 03/18] hw/pci-host/bonito: Use... Huacai Chen
- [PATCH 05/18] hw/pci-host/bonito: Simplify so... Philippe Mathieu-Daudé
- [PATCH 04/18] hw/pci-host/bonito: Use pci_con... Philippe Mathieu-Daudé
- Re: [PATCH 04/18] hw/pci-host/bonito: Use... Huacai Chen
- [RFC PATCH 06/18] hw/pci-host/bonito: Do not ... Philippe Mathieu-Daudé
- [PATCH 07/18] hw/pci-host/bonito: Make BONPON... Philippe Mathieu-Daudé
- [PATCH 10/18] hw/pci-host/bonito: Rename PCI ... Philippe Mathieu-Daudé
- [RFC PATCH 08/18] hw/pci-host/bonito: Remap P... Philippe Mathieu-Daudé
- [PATCH 16/18] hw/pci-host/bonito: Create TYPE... Philippe Mathieu-Daudé
- [PATCH 09/18] hw/pci-host/bonito: Rename nort... Philippe Mathieu-Daudé
- [PATCH 11/18] hw/pci-host/bonito: Rename PCI ... Philippe Mathieu-Daudé