Patchew URL: https://patchew.org/QEMU/1610080146-14968-1-git-send-email-tsimp...@quicinc.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1610080146-14968-1-git-send-email-tsimp...@quicinc.com Subject: [PATCH v6 00/35] Hexagon patch series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1610080146-14968-1-git-send-email-tsimp...@quicinc.com -> patchew/1610080146-14968-1-git-send-email-tsimp...@quicinc.com - [tag update] patchew/me3p282mb17456b93ae422008f433c50dfc...@me3p282mb1745.ausp282.prod.outlook.com -> patchew/me3p282mb17456b93ae422008f433c50dfc...@me3p282mb1745.ausp282.prod.outlook.com Switched to a new branch 'test' 4affae0 Add newline when generating Dockerfile 4dfa4fc Auto-import Docker support files f6826f4 Add Dockerfile for hexagon eab6033 Hexagon build infrastructure 2f874bd Hexagon (tests/tcg/hexagon) TCG tests 199c6a8 Hexagon (linux-user/hexagon) Linux user emulation 042fe41 Hexagon (target/hexagon) translation 64f32a2 Hexagon (target/hexagon) TCG for floating point instructions abce063 Hexagon (target/hexagon) TCG for instructions with multiple definitions fb62368 Hexagon (target/hexagon) TCG generation e72f87e Hexagon (target/hexagon) instruction classes 5145d6f Hexagon (target/hexagon) macros e2ba52e Hexagon (target/hexagon) opcode data structures 86ec014 Hexagon (target/hexagon) generater phase 4 - decode tree 0895ec5 Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree e2828ec Hexagon (target/hexagon) generator phase 2 - generate header files 7b8a96d Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics df51f7b Hexagon (target/hexagon/imported) arch import 1340e17 Hexagon (target/hexagon/fma_emu.[ch]) utility functions 028bca3 Hexagon (target/hexagon/conv_emu.[ch]) utility functions abc4cd4 Hexagon (target/hexagon/arch.[ch]) utility functions 4f0edc0 Hexagon (target/hexagon) instruction printing 84be801 Hexagon (target/hexagon) instruction/packet decode eed40dd Hexagon (target/hexagon) instruction attributes bb930be Hexagon (target/hexagon) register fields 4a0da26 Hexagon (target/hexagon) instruction and packet types e5e7712 Hexagon (target/hexagon) architecture types 33d7340 Hexagon (target/hexagon) GDB Stub ac40859 Hexagon (target/hexagon) scalar core helpers 0da88d6 Hexagon (target/hexagon) register names 888dc67 Hexagon (disas) disassembler 88f2553 Hexagon (target/hexagon) scalar core definition 310aa19 Hexagon (include/elf.h) ELF machine definition ee760b0 Hexagon (target/hexagon) README 6b03a8f Hexagon Update MAINTAINERS file === OUTPUT BEGIN === 1/35 Checking commit 6b03a8fcfcec (Hexagon Update MAINTAINERS file) 2/35 Checking commit ee760b04dfce (Hexagon (target/hexagon) README) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 235 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 310aa193607a (Hexagon (include/elf.h) ELF machine definition) 4/35 Checking commit 88f255358f1c (Hexagon (target/hexagon) scalar core definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 595 lines checked Patch 4/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/35 Checking commit 888dc67b6cba (Hexagon (disas) disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 82 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 0da88d6baf42 (Hexagon (target/hexagon) register names) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 total: 0 errors, 1 warnings, 83 lines checked Patch 6/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/35 Checking commit ac408596534c (Hexagon (target/hexagon) scalar core helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 1101 lines checked Patch 7/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/35 Checking commit 33d7340a4926 (Hexagon (target/hexagon) GDB Stub) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 64 lines checked Patch 8/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/35 Checking commit e5e7712520a0 (Hexagon (target/hexagon) architecture types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 38 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 4a0da266d38d (Hexagon (target/hexagon) instruction and packet types) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 74 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit bb930be9b67a (Hexagon (target/hexagon) register fields) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #79: FILE: target/hexagon/reg_fields.h:29: +#define DEF_REG_FIELD(TAG, START, WIDTH) \ + TAG, total: 1 errors, 1 warnings, 104 lines checked Patch 11/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/35 Checking commit eed40dd414db (Hexagon (target/hexagon) instruction attributes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #37: FILE: target/hexagon/attribs.h:22: +#define DEF_ATTRIB(NAME, ...) A_##NAME, total: 1 errors, 1 warnings, 127 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 84be8015e77c (Hexagon (target/hexagon) instruction/packet decode) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #127: FILE: target/hexagon/decode.c:101: +#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH ERROR: Macros with multiple statements should be enclosed in a do - while loop #702: FILE: target/hexagon/q6v_decode.c:51: +#define DECODE_OPINFO(TAG, BEH) \ + case TAG: \ + { BEH } \ + break; \ + total: 2 errors, 1 warnings, 998 lines checked Patch 13/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/35 Checking commit 4f0edc04c7df (Hexagon (target/hexagon) instruction printing) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #58: FILE: target/hexagon/printinsn.c:43: +#define DEF_PRINTINFO(TAG, FMT, ...) \ + case TAG: \ + snprintf(buf, n, FMT, __VA_ARGS__);\ + break; total: 1 errors, 1 warnings, 186 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit abc4cd4e4e07 (Hexagon (target/hexagon/arch.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 329 lines checked Patch 15/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/35 Checking commit 028bca300015 (Hexagon (target/hexagon/conv_emu.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 208 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 1340e17f3da3 (Hexagon (target/hexagon/fma_emu.[ch]) utility functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #407: FILE: target/hexagon/fma_emu.c:392: +static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \ WARNING: Block comments use a leading /* on a separate line #411: FILE: target/hexagon/fma_emu.c:396: + /* result zero */ \ WARNING: Block comments use a leading /* on a separate line #419: FILE: target/hexagon/fma_emu.c:404: + /* Normalize right */ \ WARNING: Block comments use a leading /* on a separate line #420: FILE: target/hexagon/fma_emu.c:405: + /* We want MANTBITS bits of mantissa plus the leading one. */ \ WARNING: Block comments use a leading /* on a separate line #421: FILE: target/hexagon/fma_emu.c:406: + /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \ WARNING: Block comments use a leading /* on a separate line #422: FILE: target/hexagon/fma_emu.c:407: + /* So we need to normalize right while the high word is non-zero and \ WARNING: Block comments should align the * on each line #423: FILE: target/hexagon/fma_emu.c:408: + /* So we need to normalize right while the high word is non-zero and \ + * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \ WARNING: Block comments use a leading /* on a separate line #428: FILE: target/hexagon/fma_emu.c:413: + /* \ WARNING: Block comments use a leading /* on a separate line #438: FILE: target/hexagon/fma_emu.c:423: + /* \ WARNING: Block comments use a leading /* on a separate line #445: FILE: target/hexagon/fma_emu.c:430: + /* \ WARNING: Block comments use a leading /* on a separate line #454: FILE: target/hexagon/fma_emu.c:439: + /* OK, we're relatively canonical... now we need to round */ \ WARNING: Block comments use a leading /* on a separate line #459: FILE: target/hexagon/fma_emu.c:444: + /* Chop and we're done */ \ WARNING: Block comments use a leading /* on a separate line #473: FILE: target/hexagon/fma_emu.c:458: + /* round up if guard is 1, down if guard is zero */ \ WARNING: Block comments use a leading /* on a separate line #476: FILE: target/hexagon/fma_emu.c:461: + /* exactly .5, round up if odd */ \ WARNING: Block comments use a leading /* on a separate line #482: FILE: target/hexagon/fma_emu.c:467: + /* \ WARNING: Block comments use a leading /* on a separate line #491: FILE: target/hexagon/fma_emu.c:476: + /* Overflow? */ \ WARNING: Block comments use a leading /* on a separate line #493: FILE: target/hexagon/fma_emu.c:478: + /* Yep, inf result */ \ WARNING: Block comments use a leading /* on a separate line #515: FILE: target/hexagon/fma_emu.c:500: + /* Underflow? */ \ WARNING: Block comments use a leading /* on a separate line #517: FILE: target/hexagon/fma_emu.c:502: + /* Leading one means: No, we're normal. So, we should be done... */ \ total: 1 errors, 19 warnings, 738 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit df51f7b74b8b (Hexagon (target/hexagon/imported) arch import) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 9228 lines checked Patch 18/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/35 Checking commit 7b8a96dee7d0 (Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 ERROR: suspicious ; after while (0) #83: FILE: target/hexagon/gen_semantics.c:61: + } while (0); total: 1 errors, 1 warnings, 88 lines checked Patch 19/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/35 Checking commit e2828ec3db76 (Hexagon (target/hexagon) generator phase 2 - generate header files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100755 WARNING: line over 80 characters #990: FILE: target/hexagon/gen_tcg_funcs.py:53: + f.write(" tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 1]);\n" % \ WARNING: line over 80 characters #1071: FILE: target/hexagon/gen_tcg_funcs.py:134: + f.write(" TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" % \ WARNING: line over 80 characters #1153: FILE: target/hexagon/gen_tcg_funcs.py:216: + f.write(" hex_gpr[%s%sN + 1]);\n" % \ WARNING: line over 80 characters #1252: FILE: target/hexagon/gen_tcg_funcs.py:315: + f.write(" gen_log_predicated_reg_write_pair(%s%sN, %s%sV, insn->slot);\n" % \ total: 0 errors, 5 warnings, 1601 lines checked Patch 20/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/35 Checking commit 0895ec58b938 (Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #64: FILE: target/hexagon/gen_dectree_import.c:44: +#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \ + [TAG] = BEH, ERROR: Macros with complex values should be enclosed in parenthesis #66: FILE: target/hexagon/gen_dectree_import.c:46: +#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \ + [TAG] = BEH, ERROR: Macros with complex values should be enclosed in parenthesis #74: FILE: target/hexagon/gen_dectree_import.c:54: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #83: FILE: target/hexagon/gen_dectree_import.c:63: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: suspicious ; after while (0) #180: FILE: target/hexagon/gen_dectree_import.c:160: + } while (0); total: 5 errors, 1 warnings, 187 lines checked Patch 21/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/35 Checking commit 86ec0145726f (Hexagon (target/hexagon) generater phase 4 - decode tree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100755 total: 0 errors, 1 warnings, 351 lines checked Patch 22/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/35 Checking commit e2ba52e8a445 (Hexagon (target/hexagon) opcode data structures) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #56: FILE: target/hexagon/opcodes.c:41: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO, ERROR: Macros with complex values should be enclosed in parenthesis #66: FILE: target/hexagon/opcodes.c:51: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS, ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: target/hexagon/opcodes.c:61: +#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS, ERROR: Macros with complex values should be enclosed in parenthesis #84: FILE: target/hexagon/opcodes.c:69: +#define DEF_SHORTCODE(TAG, SHORTCODE) [TAG] = #SHORTCODE, ERROR: Macros with complex values should be enclosed in parenthesis #123: FILE: target/hexagon/opcodes.c:108: +#define ATTRIBS(...) , ## __VA_ARGS__, 0 total: 5 errors, 1 warnings, 205 lines checked Patch 23/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/35 Checking commit 5145d6f93f32 (Hexagon (target/hexagon) macros) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 24/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/35 Checking commit e72f87e2775b (Hexagon (target/hexagon) instruction classes) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: target/hexagon/iclass.c:23: +#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \ + [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS, ERROR: Macros with complex values should be enclosed in parenthesis #42: FILE: target/hexagon/iclass.c:25: +#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \ + [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS, ERROR: Macros with complex values should be enclosed in parenthesis #123: FILE: target/hexagon/iclass.h:27: +#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), ERROR: Macros with complex values should be enclosed in parenthesis #124: FILE: target/hexagon/iclass.h:28: +#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE), total: 4 errors, 1 warnings, 174 lines checked Patch 25/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/35 Checking commit fb62368998e8 (Hexagon (target/hexagon) TCG generation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 259 lines checked Patch 26/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/35 Checking commit abce063e35c8 (Hexagon (target/hexagon) TCG for instructions with multiple definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 198 lines checked Patch 27/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 28/35 Checking commit 64f32a27265b (Hexagon (target/hexagon) TCG for floating point instructions) 29/35 Checking commit 042fe41ec4e9 (Hexagon (target/hexagon) translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 778 lines checked Patch 29/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/35 Checking commit 199c6a800b5f (Hexagon (linux-user/hexagon) Linux user emulation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #122: FILE: linux-user/hexagon/cpu_loop.c:76: + EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n", total: 1 errors, 1 warnings, 1031 lines checked Patch 30/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/35 Checking commit 2f874bd93b87 (Hexagon (tests/tcg/hexagon) TCG tests) ERROR: line over 90 characters #23: FILE: tests/tcg/configure.sh:73: +: ${cross_cc_cflags_hexagon="-mv67 -O2 -static -Wno-incompatible-pointer-types -Wno-undefined-internal"} ERROR: line over 90 characters #32: FILE: tests/tcg/configure.sh:99: + alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 2 errors, 1 warnings, 3081 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit eab60333f5d6 (Hexagon build infrastructure) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 WARNING: line over 80 characters #56: FILE: scripts/qemu-binfmt-conf.sh:139: +hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00' ERROR: line over 90 characters #57: FILE: scripts/qemu-binfmt-conf.sh:140: +hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff' total: 1 errors, 2 warnings, 220 lines checked Patch 32/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/35 Checking commit f6826f42b97e (Add Dockerfile for hexagon) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100755 WARNING: line over 80 characters #78: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:63: + -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \ ERROR: line over 90 characters #105: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:90: + CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ ERROR: line over 90 characters #142: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:127: + CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \ total: 2 errors, 2 warnings, 169 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 4dfa4fc7fa27 (Auto-import Docker support files) 35/35 Checking commit 4affae013f97 (Add newline when generating Dockerfile) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1610080146-14968-1-git-send-email-tsimp...@quicinc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com