On Fri, 8 Jan 2021 at 15:00, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Fri, 8 Jan 2021 at 13:50, Peter Maydell <peter.mayd...@linaro.org> wrote: > > > > On Sat, 2 Jan 2021 at 15:14, Roman Bolshakov <r.bolsha...@yadro.com> wrote: > > > > > > ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first deprecated > > > in macOS 11.0 - Use -[NSWorkspace openURL:] instead. > > > [-Wdeprecated-declarations] > > > if ([[NSWorkspace sharedWorkspace] openFile: full_file_path] == > > > YES) { > > > ^ > > > /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWorkspace.h:350:1: > > > note: > > > 'openFile:' has been explicitly marked deprecated here > > > - (BOOL)openFile:(NSString *)fullPath API_DEPRECATED("Use -[NSWorkspace > > > openURL:] instead.", macos(10.0, 11.0)); > > > ^ > > > > > > Signed-off-by: Roman Bolshakov <r.bolsha...@yadro.com> > > > --- > > > > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > > So I was just trying to test this patch, and I found that at least > for me the osx menu bar has stopped working in QEMU -- keyboard > shortcuts to it still work but none of the menu buttons respond > to the mouse. Does that happen for anybody else?
This menu bar breakage appears to be caused by this patch. I have no idea why, because the patch looks pretty harmless. Nonetheless, I'm going to have to drop it from my queue. thanks -- PMM