On 1/8/21 11:42 PM, Alex Bennée wrote: > From: Keith Packard <kei...@keithp.com> > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c -> linux-user/semihost.c > > The build system was modified use a new config variable, > CONFIG_ARM_COMPATIBLE_SEMIHOSTING, which has been added to the ARM > softmmu and linux-user default configs. The contents of the source > files has not been changed in this patch. > > Signed-off-by: Keith Packard <kei...@keithp.com> > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > Message-Id: <20210107170717.2098982-2-kei...@keithp.com> > --- > default-configs/devices/arm-softmmu.mak | 1 + > default-configs/targets/aarch64-linux-user.mak | 1 + > default-configs/targets/aarch64_be-linux-user.mak | 1 + > default-configs/targets/arm-linux-user.mak | 1 + > default-configs/targets/armeb-linux-user.mak | 1 + > target/arm/arm-semi.c => hw/semihosting/common-semi.c | 0 > linux-user/{arm => }/semihost.c | 0 > hw/semihosting/Kconfig | 3 +++ > hw/semihosting/meson.build | 3 +++ > linux-user/arm/meson.build | 3 --- > linux-user/meson.build | 1 + > target/arm/meson.build | 2 -- > 12 files changed, 12 insertions(+), 5 deletions(-) > rename target/arm/arm-semi.c => hw/semihosting/common-semi.c (100%) > rename linux-user/{arm => }/semihost.c (100%) ...
> diff --git a/hw/semihosting/Kconfig b/hw/semihosting/Kconfig > index efe0a30734..4c30dc6b16 100644 > --- a/hw/semihosting/Kconfig > +++ b/hw/semihosting/Kconfig > @@ -1,3 +1,6 @@ > > config SEMIHOSTING > bool > + > +config ARM_COMPATIBLE_SEMIHOSTING > + bool This misses: "select SEMIHOSTING" 'SEMIHOSTING' is a bit confusing. Wondering about better names, maybe SEMIHOSTING_HOST_CONSOLE is clearer? (question not related to this patch).