On Fri, 15 Jan 2021 09:07:47 +0000 "Zhang, Chen" <chen.zh...@intel.com> wrote:
> > -----Original Message----- > > From: Lukas Straub <lukasstra...@web.de> > > Sent: Thursday, January 14, 2021 9:45 PM > > To: Zhang, Chen <chen.zh...@intel.com> > > Cc: Jason Wang <jasow...@redhat.com>; qemu-dev <qemu- > > de...@nongnu.org>; Eric Blake <ebl...@redhat.com>; Dr. David Alan > > Gilbert <dgilb...@redhat.com>; Markus Armbruster <arm...@redhat.com>; > > Zhang Chen <zhangc...@gmail.com> > > Subject: Re: [PATCH 3/3] net/colo-compare: Add handler for passthrough > > connection > > > > On Thu, 24 Dec 2020 09:09:18 +0800 > > Zhang Chen <chen.zh...@intel.com > wrote: > > > > > From: Zhang Chen <chen.zh...@intel.com> > > > > > > Currently, we just use guest's TCP/UDP source port as the key to > > > bypass certain network traffic. > > > > > > Signed-off-by: Zhang Chen <chen.zh...@intel.com> > > > --- > > > net/colo-compare.c | 49 > > > ++++++++++++++++++++++++++++++++++++++++++++++ > > > net/colo-compare.h | 2 ++ > > > net/net.c | 27 +++++++++++++++++++++++++ > > > 3 files changed, 78 insertions(+) > > > > > > diff --git a/net/colo-compare.c b/net/colo-compare.c index > > > 337025b44f..11a32caa9b 100644 > > > --- a/net/colo-compare.c > > > +++ b/net/colo-compare.c > > > @@ -46,6 +46,9 @@ static QTAILQ_HEAD(, CompareState) net_compares = > > > static NotifierList colo_compare_notifiers = > > > NOTIFIER_LIST_INITIALIZER(colo_compare_notifiers); > > > > > > +static QLIST_HEAD(, PassthroughEntry) passthroughlist = > > > + QLIST_HEAD_INITIALIZER(passthroughlist); > > > + > > > > Hi, > > I think this should be per colo-compare instance e.g. inside 'struct > > CompareState'. > > It looks QMP and HMP also need to add colo-compare object ID to control it. > Do we need make this command more general? Yes, it gives more flexibility. For example if the VM a "public" and a separate "management" network interface, passthrough can then be enabled just on the "management" interface. Regards, Lukas Straub > Thanks > Chen > > > > > > [...]
pgp8Kmy1e0Qfg.pgp
Description: OpenPGP digital signature