Patchew URL: https://patchew.org/QEMU/20210115210456.1053477-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210115210456.1053477-1-richard.hender...@linaro.org Subject: [PATCH v2 00/22] tcg: backend constraints cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210115210456.1053477-1-richard.hender...@linaro.org -> patchew/20210115210456.1053477-1-richard.hender...@linaro.org Switched to a new branch 'test' d68e872 tcg: Remove TCG_TARGET_CON_SET_H e95d871 tcg/tci: Split out constraint sets to tcg-target-con-set.h 1b77fd4 tcg/sparc: Split out constraint sets to tcg-target-con-set.h 8fbb090 tcg/s390: Split out constraint sets to tcg-target-con-set.h 30a9f30 tcg/riscv: Split out constraint sets to tcg-target-con-set.h 0cd363f tcg/ppc: Split out constraint sets to tcg-target-con-set.h 99ea40d tcg/mips: Split out constraint sets to tcg-target-con-set.h 3bf16ec tcg/arm: Split out constraint sets to tcg-target-con-set.h b9a5ab6 tcg/aarch64: Split out constraint sets to tcg-target-con-set.h 40105f9 tcg/i386: Split out constraint sets to tcg-target-con-set.h 1a6d1cf tcg: Remove TCG_TARGET_CON_STR_H bf438b2 tcg/sparc: Split out target constraints to tcg-target-con-str.h 2b16079 tcg/s390: Split out target constraints to tcg-target-con-str.h a8d918c tcg/riscv: Split out target constraints to tcg-target-con-str.h 3a49051 tcg/mips: Split out target constraints to tcg-target-con-str.h 7d43318 tcg/tci: Split out target constraints to tcg-target-con-str.h 639d63b tcg/ppc: Split out target constraints to tcg-target-con-str.h 7be4d7c tcg/aarch64: Split out target constraints to tcg-target-con-str.h 9728a63 tcg/arm: Split out target constraints to tcg-target-con-str.h 899b298 tcg/i386: Split out target constraints to tcg-target-con-str.h 185b424 tcg/i386: Move constraint type check to tcg_target_const_match 50f1d89 tcg/tci: Drop L and S constraints === OUTPUT BEGIN === 1/22 Checking commit 50f1d89ed020 (tcg/tci: Drop L and S constraints) 2/22 Checking commit 185b424e1b0d (tcg/i386: Move constraint type check to tcg_target_const_match) 3/22 Checking commit 899b298a9cad (tcg/i386: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #224: FILE: tcg/tcg.c:2465: +#define CONST(CASE, MASK) \ + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #225: FILE: tcg/tcg.c:2466: + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: Macros with multiple statements should be enclosed in a do - while loop #226: FILE: tcg/tcg.c:2467: +#define REGS(CASE, MASK) \ + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #227: FILE: tcg/tcg.c:2468: + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; total: 4 errors, 1 warnings, 213 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 9728a63c04b5 (tcg/arm: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 106 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit 7be4d7c469dd (tcg/aarch64: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 89 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 639d63b228ab (tcg/ppc: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 7d43318efe71 (tcg/tci: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 37 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 3a49051cb9f3 (tcg/mips: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 113 lines checked Patch 8/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/22 Checking commit a8d918cc404a (tcg/riscv: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 89 lines checked Patch 9/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/22 Checking commit 2b1607997ad9 (tcg/s390: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 75 lines checked Patch 10/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/22 Checking commit bf438b27c489 (tcg/sparc: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 101 lines checked Patch 11/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/22 Checking commit 1a6d1cffb02f (tcg: Remove TCG_TARGET_CON_STR_H) 13/22 Checking commit 40105f91bf74 (tcg/i386: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #437: FILE: tcg/tcg.c:362: +#define C_O0_I1(I1) C_PFX1(c_o0_i1_, I1), ERROR: Macros with complex values should be enclosed in parenthesis #438: FILE: tcg/tcg.c:363: +#define C_O0_I2(I1, I2) C_PFX2(c_o0_i2_, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #439: FILE: tcg/tcg.c:364: +#define C_O0_I3(I1, I2, I3) C_PFX3(c_o0_i3_, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #440: FILE: tcg/tcg.c:365: +#define C_O0_I4(I1, I2, I3, I4) C_PFX4(c_o0_i4_, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #442: FILE: tcg/tcg.c:367: +#define C_O1_I1(O1, I1) C_PFX2(c_o1_i1_, O1, I1), ERROR: Macros with complex values should be enclosed in parenthesis #443: FILE: tcg/tcg.c:368: +#define C_O1_I2(O1, I1, I2) C_PFX3(c_o1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #444: FILE: tcg/tcg.c:369: +#define C_O1_I3(O1, I1, I2, I3) C_PFX4(c_o1_i3_, O1, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #445: FILE: tcg/tcg.c:370: +#define C_O1_I4(O1, I1, I2, I3, I4) C_PFX5(c_o1_i4_, O1, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #447: FILE: tcg/tcg.c:372: +#define C_N1_I2(O1, I1, I2) C_PFX3(c_n1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #449: FILE: tcg/tcg.c:374: +#define C_O2_I1(O1, O2, I1) C_PFX3(c_o2_i1_, O1, O2, I1), ERROR: Macros with complex values should be enclosed in parenthesis #450: FILE: tcg/tcg.c:375: +#define C_O2_I2(O1, O2, I1, I2) C_PFX4(c_o2_i2_, O1, O2, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #451: FILE: tcg/tcg.c:376: +#define C_O2_I3(O1, O2, I1, I2, I3) C_PFX5(c_o2_i3_, O1, O2, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #452: FILE: tcg/tcg.c:377: +#define C_O2_I4(O1, O2, I1, I2, I3, I4) \ + C_PFX6(c_o2_i4_, O1, O2, I1, I2, I3, I4), total: 13 errors, 1 warnings, 518 lines checked Patch 13/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/22 Checking commit b9a5ab672ee0 (tcg/aarch64: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 224 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit 3bf16ec2a760 (tcg/arm: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 192 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 99ea40de367b (tcg/mips: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 208 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 0cd363f92a00 (tcg/ppc: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 270 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 30a9f302a4d9 (tcg/riscv: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 total: 0 errors, 1 warnings, 180 lines checked Patch 18/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/22 Checking commit 8fbb090d9ff9 (tcg/s390: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 228 lines checked Patch 19/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/22 Checking commit 1b77fd47bccc (tcg/sparc: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 183 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit e95d8717a587 (tcg/tci: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 392 lines checked Patch 21/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/22 Checking commit d68e8723f9fe (tcg: Remove TCG_TARGET_CON_SET_H) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210115210456.1053477-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
