On Sat, Jan 16, 2021 at 11:07 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > On 1/16/21 3:03 PM, Bin Meng wrote: > > Hi Philippe, > > > > On Fri, Jan 15, 2021 at 11:31 PM Philippe Mathieu-Daudé <f4...@amsat.org> > > wrote: > >> > >> Hi, > >> > >> This is how I understand the ecSPI reset works, after > >> looking at the IMX6DQRM.pdf datasheet. > >> > >> This is a respin of Ben's v5 series [*]. > >> > >> Since v6: > >> - Dropped "Reduce 'change_mask' variable scope" patch > >> - Fixed inverted reset logic > >> - Added Juan R-b tags > >> - Removed 'RFC' tag as tests pass > >> > >> Based-on: <1608688825-81519-1-git-send-email-bmeng...@gmail.com> > >> (queued on riscv-next). > >> > > > > This series dropped my imx_spi_soft_reset() change that has the > > imx_spi_update_irq() moved from imx_spi_reset(). May I know why? > > Because we don't need it. My comment without looking at the datasheet > was incorrect: there is only one single reset on the block.
Oh, you must have missed Peter's comments. See his comments here: http://patchwork.ozlabs.org/project/qemu-devel/patch/20201202144523.24526-2-bmeng...@gmail.com/ Regards, Bin
