Re: [PATCH v1 1/1] riscv: Pass RISCVHartArrayState by pointer

[Richard Henderson]

On 1/15/21 1:00 PM, Alistair Francis wrote:
> +bool riscv_is_32bit(RISCVHartArrayState *harts)
>  {
> -    RISCVCPU hart = harts.harts[0];
> +    RISCVCPU hart = harts->harts[0];

This is a large structure copy as well.


>      return riscv_cpu_is_32bit(&hart.env);
>  }

Better as

  &harts->harts[0].env

surely.


r~