From: Markus Armbruster <arm...@redhat.com> QAPISchemaModularCVisitor._begin_system_module() is actually just for the builtin module. Rename it to ._begin_builtin_module() and drop its useless @name parameter.
Signed-off-by: Markus Armbruster <arm...@redhat.com> Signed-off-by: John Snow <js...@redhat.com> --- scripts/qapi/gen.py | 4 ++-- scripts/qapi/types.py | 2 +- scripts/qapi/visit.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index 3b7eddc1c21..9f850d23646 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py @@ -295,7 +295,7 @@ def write(self, output_dir: str, opt_builtins: bool = False) -> None: genc.write(output_dir) genh.write(output_dir) - def _begin_system_module(self, name: None) -> None: + def _begin_builtin_module(self) -> None: pass def _begin_user_module(self, name: str) -> None: @@ -305,7 +305,7 @@ def visit_module(self, module: QAPISchemaModule) -> None: if module.system_module: if self._builtin_blurb: self._add_system_module(None, self._builtin_blurb) - self._begin_system_module(module.name) + self._begin_builtin_module() else: # The built-in module has not been created. No code may # be generated. diff --git a/scripts/qapi/types.py b/scripts/qapi/types.py index 2b4916cdaa1..dbf58c0b91d 100644 --- a/scripts/qapi/types.py +++ b/scripts/qapi/types.py @@ -271,7 +271,7 @@ def __init__(self, prefix: str): prefix, 'qapi-types', ' * Schema-defined QAPI types', ' * Built-in QAPI types', __doc__) - def _begin_system_module(self, name: None) -> None: + def _begin_builtin_module(self) -> None: self._genc.preamble_add(mcgen(''' #include "qemu/osdep.h" #include "qapi/dealloc-visitor.h" diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py index 339f1521524..568ba35592c 100644 --- a/scripts/qapi/visit.py +++ b/scripts/qapi/visit.py @@ -305,7 +305,7 @@ def __init__(self, prefix: str): prefix, 'qapi-visit', ' * Schema-defined QAPI visitors', ' * Built-in QAPI visitors', __doc__) - def _begin_system_module(self, name: None) -> None: + def _begin_builtin_module(self) -> None: self._genc.preamble_add(mcgen(''' #include "qemu/osdep.h" #include "qapi/error.h" -- 2.26.2