On Wed, Jan 20, 2021 at 03:42:32PM +0100, Paolo Bonzini wrote: > The real driver for these patches is to send all QemuOpts user input > to qemu_opts_parse_noisily, for consistency in the command line > parsing code and to effectively outlaw "help" and "?" QemuOpts > suboptions. vnc_parse is the only function that is still using > qemu_opts_parse.
Should we maybe move vnc to qapi cmd line parsing instead? > In order to remove the non-command-line callers of vnc_parse, > I am removing the deprecated QMP change command but also its HMP > veneer "change vnc TARGET", whose usecase is somewhat unclear to > me. Hmm. It's been a few years ... IIRC back when this was added the main use case was having a way to enable/disable the vnc server. Not sure this is still needed/useful. These days you can effectively disable vnc access by expiring the password (or not setting one in the first place) without re-configuring the vnc server. Also the race where qemu allowed passwordless connects between start and password being set via monitor is long gone. So, all in all I feel a bit uncomfortable dropping this without the usual deprecation period. No strong objections though. take care, Gerd
