Patchew URL: https://patchew.org/QEMU/20210129201028.787853-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210129201028.787853-1-richard.hender...@linaro.org Subject: [PATCH v3 00/24] tcg: backend constraints cleanup === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210129201028.787853-1-richard.hender...@linaro.org -> patchew/20210129201028.787853-1-richard.hender...@linaro.org Auto packing the repository for optimum performance. You may also run "git gc" manually. See "git help gc" for more information. Switched to a new branch 'test' 99968b1 tcg: Remove TCG_TARGET_CON_SET_H f4db259 tcg/tci: Split out constraint sets to tcg-target-con-set.h 0f05bc5 tcg/sparc: Split out constraint sets to tcg-target-con-set.h 6877c98 tcg/s390: Split out constraint sets to tcg-target-con-set.h 2e37d8d tcg/riscv: Split out constraint sets to tcg-target-con-set.h c6ec388 tcg/ppc: Split out constraint sets to tcg-target-con-set.h 9785a4f tcg/mips: Split out constraint sets to tcg-target-con-set.h c347e78 tcg/arm: Split out constraint sets to tcg-target-con-set.h b868c9a tcg/aarch64: Split out constraint sets to tcg-target-con-set.h a792388 tcg/i386: Split out constraint sets to tcg-target-con-set.h 96c2084 tcg: Remove TCG_TARGET_CON_STR_H 5197aa7 tcg/sparc: Split out target constraints to tcg-target-con-str.h dee58ce tcg/s390: Split out target constraints to tcg-target-con-str.h 8bdfd7d tcg/riscv: Split out target constraints to tcg-target-con-str.h 5574bf9 tcg/mips: Split out target constraints to tcg-target-con-str.h ef40966 tcg/tci: Split out target constraints to tcg-target-con-str.h 109e507 tcg/ppc: Split out target constraints to tcg-target-con-str.h fd98327 tcg/aarch64: Split out target constraints to tcg-target-con-str.h fd76598 tcg/arm: Split out target constraints to tcg-target-con-str.h d8bdc37 tcg/i386: Split out target constraints to tcg-target-con-str.h d1febe5 tcg/i386: Tidy register constraint definitions 8768867 tcg/i386: Move constraint type check to tcg_target_const_match 6d85b0e tcg/tci: Remove TCG_TARGET_HAS_* ifdefs c1a401c tcg/tci: Drop L and S constraints === OUTPUT BEGIN === 1/24 Checking commit c1a401cedd92 (tcg/tci: Drop L and S constraints) 2/24 Checking commit 6d85b0e6c1ae (tcg/tci: Remove TCG_TARGET_HAS_* ifdefs) 3/24 Checking commit 8768867ab61f (tcg/i386: Move constraint type check to tcg_target_const_match) 4/24 Checking commit d1febe5a517c (tcg/i386: Tidy register constraint definitions) 5/24 Checking commit d8bdc376cf31 (tcg/i386: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: new file mode 100644 ERROR: Macros with multiple statements should be enclosed in a do - while loop #191: FILE: tcg/tcg.c:2471: +#define CONST(CASE, MASK) \ + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #192: FILE: tcg/tcg.c:2472: + case CASE: def->args_ct[i].ct |= MASK; ct_str++; break; ERROR: Macros with multiple statements should be enclosed in a do - while loop #193: FILE: tcg/tcg.c:2473: +#define REGS(CASE, MASK) \ + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; ERROR: trailing statements should be on next line #194: FILE: tcg/tcg.c:2474: + case CASE: def->args_ct[i].regs |= MASK; ct_str++; break; total: 4 errors, 1 warnings, 175 lines checked Patch 5/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/24 Checking commit fd76598d1908 (tcg/arm: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 111 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit fd98327bcedb (tcg/aarch64: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 89 lines checked Patch 7/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/24 Checking commit 109e5079eec2 (tcg/ppc: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 8/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/24 Checking commit ef40966adeac (tcg/tci: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 37 lines checked Patch 9/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/24 Checking commit 5574bf9f77f1 (tcg/mips: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 124 lines checked Patch 10/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/24 Checking commit 8bdfd7ddf3c3 (tcg/riscv: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 91 lines checked Patch 11/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/24 Checking commit dee58ce89f28 (tcg/s390: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 99 lines checked Patch 12/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/24 Checking commit 5197aa7e54eb (tcg/sparc: Split out target constraints to tcg-target-con-str.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 141 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 96c2084181af (tcg: Remove TCG_TARGET_CON_STR_H) 15/24 Checking commit a792388c360a (tcg/i386: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 ERROR: Macros with complex values should be enclosed in parenthesis #445: FILE: tcg/tcg.c:362: +#define C_O0_I1(I1) C_PFX1(c_o0_i1_, I1), ERROR: Macros with complex values should be enclosed in parenthesis #446: FILE: tcg/tcg.c:363: +#define C_O0_I2(I1, I2) C_PFX2(c_o0_i2_, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #447: FILE: tcg/tcg.c:364: +#define C_O0_I3(I1, I2, I3) C_PFX3(c_o0_i3_, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #448: FILE: tcg/tcg.c:365: +#define C_O0_I4(I1, I2, I3, I4) C_PFX4(c_o0_i4_, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #450: FILE: tcg/tcg.c:367: +#define C_O1_I1(O1, I1) C_PFX2(c_o1_i1_, O1, I1), ERROR: Macros with complex values should be enclosed in parenthesis #451: FILE: tcg/tcg.c:368: +#define C_O1_I2(O1, I1, I2) C_PFX3(c_o1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #452: FILE: tcg/tcg.c:369: +#define C_O1_I3(O1, I1, I2, I3) C_PFX4(c_o1_i3_, O1, I1, I2, I3), ERROR: Macros with complex values should be enclosed in parenthesis #453: FILE: tcg/tcg.c:370: +#define C_O1_I4(O1, I1, I2, I3, I4) C_PFX5(c_o1_i4_, O1, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #455: FILE: tcg/tcg.c:372: +#define C_N1_I2(O1, I1, I2) C_PFX3(c_n1_i2_, O1, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #457: FILE: tcg/tcg.c:374: +#define C_O2_I1(O1, O2, I1) C_PFX3(c_o2_i1_, O1, O2, I1), ERROR: Macros with complex values should be enclosed in parenthesis #458: FILE: tcg/tcg.c:375: +#define C_O2_I2(O1, O2, I1, I2) C_PFX4(c_o2_i2_, O1, O2, I1, I2), ERROR: Macros with complex values should be enclosed in parenthesis #459: FILE: tcg/tcg.c:376: +#define C_O2_I3(O1, O2, I1, I2, I3) C_PFX5(c_o2_i3_, O1, O2, I1, I2, I3), WARNING: line over 80 characters #460: FILE: tcg/tcg.c:377: +#define C_O2_I4(O1, O2, I1, I2, I3, I4) C_PFX6(c_o2_i4_, O1, O2, I1, I2, I3, I4), ERROR: Macros with complex values should be enclosed in parenthesis #460: FILE: tcg/tcg.c:377: +#define C_O2_I4(O1, O2, I1, I2, I3, I4) C_PFX6(c_o2_i4_, O1, O2, I1, I2, I3, I4), WARNING: line over 80 characters #487: FILE: tcg/tcg.c:404: +#define C_O0_I4(I1, I2, I3, I4) { .args_ct_str = { #I1, #I2, #I3, #I4 } }, WARNING: line over 80 characters #491: FILE: tcg/tcg.c:408: +#define C_O1_I3(O1, I1, I2, I3) { .args_ct_str = { #O1, #I1, #I2, #I3 } }, WARNING: line over 80 characters #492: FILE: tcg/tcg.c:409: +#define C_O1_I4(O1, I1, I2, I3, I4) { .args_ct_str = { #O1, #I1, #I2, #I3, #I4 } }, WARNING: line over 80 characters #494: FILE: tcg/tcg.c:411: +#define C_N1_I2(O1, I1, I2) { .args_ct_str = { "&" #O1, #I1, #I2 } }, WARNING: line over 80 characters #497: FILE: tcg/tcg.c:414: +#define C_O2_I2(O1, O2, I1, I2) { .args_ct_str = { #O1, #O2, #I1, #I2 } }, WARNING: line over 80 characters #498: FILE: tcg/tcg.c:415: +#define C_O2_I3(O1, O2, I1, I2, I3) { .args_ct_str = { #O1, #O2, #I1, #I2, #I3 } }, ERROR: line over 90 characters #499: FILE: tcg/tcg.c:416: +#define C_O2_I4(O1, O2, I1, I2, I3, I4) { .args_ct_str = { #O1, #O2, #I1, #I2, #I3, #I4 } }, total: 14 errors, 8 warnings, 516 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit b868c9a90de0 (tcg/aarch64: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 224 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit c347e7843ba6 (tcg/arm: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 192 lines checked Patch 17/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/24 Checking commit 9785a4f2d543 (tcg/mips: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 208 lines checked Patch 18/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/24 Checking commit c6ec388f48c2 (tcg/ppc: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 270 lines checked Patch 19/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/24 Checking commit 2e37d8d1a5cf (tcg/riscv: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 180 lines checked Patch 20/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/24 Checking commit 6877c986958a (tcg/s390: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 228 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit 0f05bc563038 (tcg/sparc: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 183 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit f4db259a1a9f (tcg/tci: Split out constraint sets to tcg-target-con-set.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 319 lines checked Patch 23/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/24 Checking commit 99968b1ab26f (tcg: Remove TCG_TARGET_CON_SET_H) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210129201028.787853-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com