On 01/02/21 13:26, Greg Kurz wrote:
Is it that '-m slow' doesn't work when running 'qos-test' or
that 'make check-qtest SPEEP=slow' doesn't run the slow tests ?
The latter was discussed on IRC last year but I don't know if
anyone has tried to investigate this yet.
Nov 24 11:36:53 <groug> th_huth, Hi. FYI it seems that the meson conversion
kinda broke 'make check SPEED=slow'. Test programs aren't passed '-m slow'
Nov 24 11:51:42 <f4bug> th_huth: do you know who uses/tests SPEED=slow?
Nov 24 11:52:03 <f4bug> th_huth: I thought this was a block-related feature
Nov 24 11:52:44 <groug> f4bug, it is supposedly used by gitlab CI
Nov 24 11:52:59 <groug> .gitlab-ci.yml: MAKE_CHECK_ARGS: check-qtest
SPEED=slow
Nov 24 12:50:53 <th_huth> groug, I'm also running make check SPEED=slow
manually sometimes ... I guess that got lost in the conversion to ninja ... bonzini,
did you ever try?
Nov 24 12:51:03 <bonzini> no it shouldn't
Nov 24 12:51:21 <th_huth> let me check...
Nov 24 12:51:40 <bonzini> ah, the tests are chosen correctly but -m slow is lost
Nov 24 12:52:02 <groug> yes that's what I see
Nov 24 12:54:04 <groug> bonzini, missing bits in scripts/mtest2make.py ?
Nov 24 12:54:28 <bonzini> groug: sort of, but assuming that all executables
support -m slow wouldn't work
Cc'ing Thomas and Paolo for additional details.
Basically what's in the IRC log is still true. I'll look into using an
environment variable "SPEED" in addition to g_test_{slow,quick} in order
to restore SPEED=slow behavior.
Paolo
