Am 03.02.2021 um 13:45 hat BALATON Zoltan geschrieben: > On Wed, 3 Feb 2021, Daniel P. Berrangé wrote: > > On Tue, Feb 02, 2021 at 09:58:15PM +0100, Philippe Mathieu-Daudé wrote: > > > Follow the inclusive terminology from the "Conscious Language in your > > > Open Source Projects" guidelines [*] and replace the word "blacklist" > > > appropriately. > > > > > > Keep the --blacklist available for backward compatibility. > > > > > > [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md > > > > > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > > --- > > > docs/interop/qemu-ga.rst | 2 +- > > > qga/main.c | 6 ++++-- > > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst > > > index 9a590bf95cb..89596e646de 100644 > > > --- a/docs/interop/qemu-ga.rst > > > +++ b/docs/interop/qemu-ga.rst > > > @@ -79,7 +79,7 @@ Options > > > > > > Daemonize after startup (detach from terminal). > > > > > > -.. option:: -b, --blacklist=LIST > > > +.. option:: -b, --denylist=LIST > > > > > > Comma-separated list of RPCs to disable (no spaces, ``?`` to list > > > available RPCs). > > > diff --git a/qga/main.c b/qga/main.c > > > index 249fe06e8e5..66177b9e93d 100644 > > > --- a/qga/main.c > > > +++ b/qga/main.c > > > @@ -257,7 +257,8 @@ QEMU_COPYRIGHT "\n" > > > #ifdef _WIN32 > > > " -s, --service service commands: install, uninstall, vss-install, > > > vss-uninstall\n" > > > #endif > > > -" -b, --blacklist comma-separated list of RPCs to disable (no spaces, > > > \"?\"\n" > > > +" --blacklist backward compatible alias for --denylist > > > (deprecated)\n" > > > +" -b, --denylist comma-separated list of RPCs to disable (no spaces, > > > \"?\"\n" > > > > > > "-b" is a bit odd as a short name now, but i guess that's not the end > > of the world. > > Maybe -b, --block or --block-rpc? Not the best but at least preserves > consistency with the short option.
I was thinking about something like --blocked-rpcs, too, so +1 from me for your latter option. If we're touching these names, let's try to actually make them good, not just different. Neither --blacklist nor --denylist actually describe well what the option does. Kevin