On 2/4/21 8:58 AM, Daniel P. Berrangé wrote: > So consider you > > - Push 40 commits to tci-next with a dockerfile change in the 4th commit. > This triggers a build of the containers. > > Containers reflect your tci-next branch content. > > - Now push to master to catch up with upstream. This triggers a rebuild > becuase of if: '$CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH' > > Containers reflect your master branch content. > > - Push 40 commits to tci-next, but only the last 5 in the branch are > different from your previous commit. The container build won't > trigger, despite the branch containing a dockerfile change, because > the commit with the dockerfile wasn't changed from previous push > > > I've not dug further back into your pipeline history to verify if this > is what happened, but I've convinced myself that it is plausible
This is exactly my development process, switching between tasks on different branches as I wait for build results. > The addition of the rules to make container builds conditional has > broken the assumption that it is safe to use :latest for the docker > tag. > > I think we need to remove the rules condition Thanks for the analysis. r~
