On Tue 02 Feb 2021 01:49:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in further patches. > > Choose int return status, because bdrv_replace_node_common() has call > to bdrv_check_update_perm(), which reports int status, which seems > correct to propagate. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
I had already reviewed this one, hadn't I? Reviewed-by: Alberto Garcia <be...@igalia.com> Berto