On Mon, Feb 15, 2021 at 04:25:24PM -0600, Eric Blake wrote: > Git's default hunk pattern recognizer favors the C language, but it > also includes several built-in diff styles that give saner results in > other languages. In particular, telling git to treat all .py files as > python changes the beginning of diff hunks as follows: > > | --- a/python/qemu/machine.py > | +++ b/python/qemu/machine.py > | -@@ -337,12 +337,12 @@ class QEMUMachine: > | +@@ -337,12 +337,12 @@ def _post_shutdown(self) -> None: > | self._qmp.close() > > which makes it much easier to tell what function a patch is touching, > rather than a non-descript listing of what class contains the changes. > > Sadly, our python files that don't use .py suffix (such as numerous > iotests) do not benefit from this glob. > > Reported-by: John Snow <js...@redhat.com> > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > .gitattributes | 1 + > 1 file changed, 1 insertion(+) >
Cool stuff! I'm queueing this, if you don't mind. Reviewed-by: Cleber Rosa <cr...@redhat.com>
signature.asc
Description: PGP signature