Am 16.02.2021 um 18:16 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia <be...@igalia.com>
> diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235 > index 20d16dbf38..f5c73b9c17 100755 > --- a/tests/qemu-iotests/235 > +++ b/tests/qemu-iotests/235 > @@ -57,7 +57,7 @@ vm.add_args('-drive', 'id=src,file=' + disk) > vm.launch() > > log(vm.qmp('object-add', qom_type='throttle-group', id='tg0', > - props={ 'x-bps-total': size })) > + x_bps_total=size)) x-bps-total isn't a stable interface, I'd prefer to use limits. My patch from November [1] had this: diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235 index d1b10ac36b..2765561ada 100755 --- a/tests/qemu-iotests/235 +++ b/tests/qemu-iotests/235 @@ -56,7 +56,7 @@ vm.add_args('-drive', 'id=src,file=' + disk) vm.launch() log(vm.qmp('object-add', qom_type='throttle-group', id='tg0', - props={ 'x-bps-total': size })) + limits={ 'bps-total': size })) log(vm.qmp('blockdev-add', **{ 'node-name': 'target', The same happens in other hunks in the patch. Actually, I believe I can even merge my patch to drop 'props' while the rest of the object-add QAPIfication series isn't ready yet. Maybe I should just do that. Kevin [1] https://lists.gnu.org/archive/html/qemu-block/2020-11/msg00802.html