> > I think there are people using QEMU to run old MacOS versions on MacOS > > X/macOS and may not follow this mailing list but I'm sure they'll complain > > once you break it. > > It was not clear what "full screen APIs" refer to in my patch. Today > macOS have three different methods to enter fullscreen: > - [NSWindow -toggleFullscreen:] (the latest one) > - [NSView -enterFullScreenModeWithOptions:] > - Make a borderless window whose frame matches with the screen > > ui/cocoa checks if [NSView -enterFullScreenModeWithOptions:] exists > and uses it in this case. Otherwise, it chooses the last method. > However, the detection of [NSView -enterFullScreenModeWithOptions:] > was broken and I fixed it to find the use of [NSView > -enterFullScreenModeWithOptions:] was wrong. This patch deletes > references to [NSView -enterFullScreenModeWithOptions:] but the code > implementing the last method is still intact and properly functions.
Ah, that explains why fullscreen worked just fine when I tried it yesterday in my macos test vm. Can you update the commit message explaining this please? The text above should do it for the most part. thanks, Gerd