On 2/22/21 7:21 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request) >> { >> CPUClass *cc = CPU_GET_CLASS(cs); >> @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int >> interrupt_request) >> cc->tcg_ops->do_interrupt(cs); >> return true; >> } >> +#endif /* CONFIG_TCG */ > > I presume this function gets moved later? What does this aid in the interim? > > > r~ >
Hi Richard, actually this is a fix for an error I introduced when adding TCGOps: arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, which is TCG-only. Maybe I should extract this and make it a standalone fix. Currently, there is no real issue because the non-TCG build is not working for ARM anyway, and that's why the issue went undetected. Thanks! Claudio