On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > ESP SCSI commands are already accumulated in cmdbuf and so there is no need to > keep a separate pdma_buf buffer. Accumulate SCSI commands for PDMA transfers > in > cmdbuf instead of pdma_buf so update cmdlen accordingly and change pdma_origin > for PDMA transfers to CMD which allows the PDMA origin to be removed. > > This commit also removes a stray memcpy() from get_cmd() which is a no-op > because > cmdlen is always zero at the start of a command. > > Notionally the removal of pdma_buf from vmstate_esp_pdma also breaks migration > compatibility for the PDMA subsection until its complete removal by the end of > the series. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > --- > hw/scsi/esp.c | 56 +++++++++++++++++++------------------------ > include/hw/scsi/esp.h | 2 -- > 2 files changed, 25 insertions(+), 33 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>
