On 2/25/21 6:28 PM, Claudio Fontana wrote: > On 2/22/21 7:06 AM, Richard Henderson wrote: >> On 2/21/21 1:24 AM, Claudio Fontana wrote: >>> From: Claudio Fontana <cfont...@centriq4.arch.suse.de> >>> >>> it is needed for KVM too. >>> >>> Signed-off-by: Claudio Fontana <cfont...@suse.de> >>> --- >>> target/arm/cpu-common.c | 33 +++++++++++++++++++++++++++++++++ >>> target/arm/tcg/helper.c | 33 --------------------------------- >>> 2 files changed, 33 insertions(+), 33 deletions(-) >> >> This is related to rebuild_hflags, I assume. >> Fix that and this isn't needed. >> >> >> r~ >> > > This stuff comes in also from the dump state code, > > if (cpu_isar_feature(aa64_sve, cpu) && sve_exception_el(env, el) == 0) { > int j, zcr_len = sve_zcr_len_for_el(env, el); > ... > } > > will take another look.. >
that was in cpu.c. sve_zcr_len_for_el is also called in arch_dump.c in aarch64_write_el64_sve, via sve_current_vq(). Wonder if a stub is needed, or we need the whole implementation.. thanks, CLaudio