On Fri, Mar 5, 2021 at 1:28 PM Samuel Thibault <samuel.thiba...@gnu.org> wrote:
> Daniel P. Berrangé, le mer. 03 mars 2021 18:11:41 +0000, a ecrit: > > On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote: > > > On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault < > samuel.thiba...@gnu.org> > > > wrote: > > > > > > > > + Examples: > > > > > + hostfwd_add net0 tcp:127.0.0.1:10022-:22 > > > > > + hostfwd_add net0 tcp:[::1]:10022-[fe80::1:2:3:4]:22 > > > > > > > > Yep, that looks good to me. > > > > > > Daniel, you wanted me to use inet_parse(). > > > Is the above syntax ok with you? > > > You must have had some expectation that at least some of > > > the various flags that inet_parse() recognizes would be needed here. > > > > It feels like the ,ipv4=on|off,ipv6=on|off flags are relevant here, > > especially in the empty address case. eg > > > > tcp::10022 - attempt to listen on both ipv4 + ipv6 > > tcp::10022,ipv4=off - listen on default address, but only for ipv6 > > tcp::10022,ipv6=off - listen on default address, but only for ipv4 > > > > Basically this ends up bringing the hostfwd stuff into alignment with > > the way other backends deal with this > > I'm fine with this yes, better have a coherent user interface. > Hi. Questions regarding an empty *guest* address, e.g., either of tcp::10022-:22 tcp::10022-[]:22 Given that the code is not supposed to be able to know brackets were present (they're stripped off early on), what does the above mean w.r.t. the guest? For the host we can have "" mean listen on both IPv4 and IPv6 (by default, absent extra options like ipv4=off). But what does a guest address of "" mean? IPv4? IPv6? Both? Does an empty guest address take on the IPvN of the host's spec?
