On Mon, Mar 08, 2021 at 09:39:49PM +0530, Tarun Gupta wrote: > VFIO migration support in QEMU is experimental as of now, which was done to > provide soak time and resolve concerns regarding bit-stream. > But, with the patches discussed in > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784931.html , we have > corrected ordering of saving PCI config space and bit-stream. > > So, this patch proposes to make vfio migration support in QEMU to be enabled > by default. Tested by successfully migrating mdev device. > > Signed-off-by: Tarun Gupta <targu...@nvidia.com> > Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com> > --- > hw/vfio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index f74be78209..15e26f460b 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3199,7 +3199,7 @@ static Property vfio_pci_dev_properties[] = { > DEFINE_PROP_BIT("x-igd-opregion", VFIOPCIDevice, features, > VFIO_FEATURE_ENABLE_IGD_OPREGION_BIT, false), > DEFINE_PROP_BOOL("x-enable-migration", VFIOPCIDevice, > - vbasedev.enable_migration, false), > + vbasedev.enable_migration, true),
If it isn't experimental then why do we even need an experimental 'x-' property at all ? IOW, rather than changing this to "true", shouldn't we just be deleting the x-enable-migration property entirely and have the code just do the right thing. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|