On 2/15/21 5:44 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> + tcg_gen_deposit_i64(cpu_gpr[a->rd], bx, ax, 32, 32); >> + tcg_gen_shri_i64(bx, bx, 32); >> + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], ax, bx, 0, 32); > > I think you should pull this out as a helper: > > void gen_pextw(TCGv_i64 dl, TCGv_i64 dh, TCGv_i64 a, TCGv_i64 b); > > since you'll re-use this for PEXTLW.
Indeed, thanks :)
