Phil, On Sat, Mar 06, 2021 at 12:54:13AM +0100, Philippe Mathieu-Daudé wrote: > @@ -3188,14 +3188,15 @@ void mtree_info(bool flatview, bool dispatch_tree, > bool owner, bool disabled) > > QTAILQ_FOREACH(as, &address_spaces, address_spaces_link) { > qemu_printf("address-space: %s\n", as->name); > - mtree_print_mr(as->root, 1, 0, &ml_head, owner, disabled); > + mtree_print_mr(as->root, 1, 0, as->root->addr,
Root MR of any address space should have mr->addr==0, right? I'm slightly confused on what this patch wanted to do if so, since then "base" will always be zero.. Or am I wrong? Thanks, > + &ml_head, owner, disabled); > qemu_printf("\n"); > } > > /* print aliased regions */ > QTAILQ_FOREACH(ml, &ml_head, mrqueue) { > qemu_printf("memory-region: %s\n", memory_region_name(ml->mr)); > - mtree_print_mr(ml->mr, 1, 0, &ml_head, owner, disabled); > + mtree_print_mr(ml->mr, 1, 0, 0, &ml_head, owner, disabled); > qemu_printf("\n"); > } > > -- > 2.26.2 > -- Peter Xu