On Wed, Mar 10, 2021 at 7:53 AM Philippe Mathieu-Daudé <phi...@redhat.com> wrote: > > The same pattern is used when setting the flash in READ_ARRAY mode: > - Set the state machine command to READ_ARRAY > - Reset the write_cycle counter > - Reset the memory region in ROMD > > Refactor the current code by extracting this pattern. > It is used three times: > > - When the timer expires and not in bypass mode > > - On a read access (on invalid command). > > - When the device is initialized. Here the ROMD mode is hidden > by the memory_region_init_rom_device() call. > > pflash_register_memory(rom_mode=true) already sets the ROM device > in "read array" mode (from I/O device to ROM one). Explicit that > by renaming the function as pflash_mode_read_array(), adding > a trace event and resetting wcycle. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > hw/block/pflash_cfi02.c | 18 +++++++++--------- > hw/block/trace-events | 1 + > 2 files changed, 10 insertions(+), 9 deletions(-) >
Reviewed-by: Bin Meng <bmeng...@gmail.com>
