Re: [PATCH v3] ui/cocoa: Clear modifiers whenever possible

[Gerd Hoffmann]

  Hi,

> +            switch ([event keyCode]) {
> +                case kVK_Shift:
> +                    if (!!(modifiers & NSEventModifierFlagShift)) {
> +                        [self toggleKey:Q_KEY_CODE_SHIFT];
> +                    }

Ah, nice, this should get left-shift toggles while holding right-shift
right.

A comment describing the NSEventTypeFlagsChanged quirks would be nice to
make it easier to understand the logic of this code.  Can go as separate
patch, I'll add this to the UI queue.

thanks,
  Gerd