On Thu, 11 Mar 2021 16:54:23 +0100 Greg Kurz <gr...@kaod.org> wrote: > On Thu, 11 Mar 2021 07:31:40 -0600 > Richard Henderson <richard.hender...@linaro.org> wrote: > > > On 3/10/21 10:56 PM, David Gibson wrote: > > >> *pc = env->nip; > > >> - *cs_base = 0; > > >> - *flags = env->hflags; > > >> + *cs_base = env->hflags; > > >> + *flags = 0; > > >> } > > > > > > Ah, that one. It caused a regression, so I dropped it. I pinged > > > Richard Henderson about it, but I don't think I even had a reply. > > > > > > I'm afraid I don't have the knowledge or the time to debug this > > > myself. > > > > I missed the regression email, sorry. Do you recall what it was? > > > > r~ > > This was: > > Message-ID: <20210210043453.gi4...@yekko.fritz.box> > > On Wed, 10 Feb 2021 15:34:53 +1100 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > Well, I don't know why, but somehow this patch is breaking one of the > > acceptance tests: > > > > (043/134) > > tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_ppc64_e500: > > INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout > > reached\nOriginal status: ERROR\n{'name': > > '043-tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_ppc64_e500', > > 'logdir': > > '/home/dwg/src/qemu/build/normal/tests/results/job-2021-02-10T15.04... > > (90.26 s) > > > > From that timeout, I'm guessing something about this is causing the > > boot to wedge. > > > > So, I've removed this from my tree for now, I'll need a fixed version > > to proceed with. >
If this can help, I have run two gitlab CI pipelines against current master (371983c1f). The one without the patch passes: https://gitlab.com/gkurz/qemu/-/pipelines/269023228 The one with the patch breaks: https://gitlab.com/gkurz/qemu/-/pipelines/269077760 > Cheers, > > -- > Greg >