On Mar 12 17:28, Alex Bennée wrote: > Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Small comment below, but otherwise: Reviewed-by: Aaron Lindsay <aa...@os.amperecomputing.com> > --- > include/qemu/qemu-plugin.h | 35 ++++++++++++++++++++++++++++------- > 1 file changed, 28 insertions(+), 7 deletions(-) > > diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h > index d4adce730a..aed868d42a 100644 > --- a/include/qemu/qemu-plugin.h > +++ b/include/qemu/qemu-plugin.h > @@ -392,24 +392,45 @@ uint64_t qemu_plugin_insn_vaddr(const struct > qemu_plugin_insn *insn); > */ > void *qemu_plugin_insn_haddr(const struct qemu_plugin_insn *insn); > > -/* > - * Memory Instrumentation > - * > - * The anonymous qemu_plugin_meminfo_t and qemu_plugin_hwaddr types > - * can be used in queries to QEMU to get more information about a > - * given memory access. > +/** > + * typedef qemu_plugin_meminfo_t - opaque memory transaction handle Would it still be useful to include the types of things you can do with a qemu_plugin_meminfo_t here?
