Re: [Qemu-devel] [PATCH 5/8] tcg: Add interpreter for bytecode

[Richard Henderson]

On 09/17/2011 01:00 PM, Stefan Weil wrote:
> +#if TCG_TARGET_HAS_ext8s_i32
> +        case INDEX_op_ext8s_i32:
> +            t0 = *tb_ptr++;
> +            t1 = tci_read_r8s(&tb_ptr);
> +            tci_write_reg32(t0, t1);
> +            break;
> +#endif

You really ought not need all these ifdefs.

> +#if TCG_TARGET_HAS_rot_i64
> +        case INDEX_op_rotl_i64:
> +        case INDEX_op_rotr_i64:
> +            TODO();
> +            break;
> +#endif

Eh?  Just the same as your rot_i32 implementations,
with different types.


r~