On 3/11/21 3:39 PM, Richard Henderson wrote: > Actually print arguments as opposed to simply the opcodes > and, uselessly, the argument counts. Reuse all of the helpers > developed as part of the interpreter. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > meson.build | 2 +- > include/tcg/tcg-opc.h | 2 - > disas/tci.c | 61 --------- > tcg/tci.c | 283 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 284 insertions(+), 64 deletions(-) > delete mode 100644 disas/tci.c
> +#if TCG_TARGET_REG_BITS == 32 > + case INDEX_op_setcond2_i32: > + tci_args_rrrrrc(&tb_ptr, &r0, &r1, &r2, &r3, &r4, &c); > + info->fprintf_func(info->stream, "%-12s %s,%s,%s,%s,%s,%s", > + op_name, str_r(r0), str_r(r1), str_r(r2), > + str_r(r3), str_r(r4), str_c(c)); > + break; > + > + case INDEX_op_brcond2_i32: > + tci_args_rrrrcl(&tb_ptr, &r0, &r1, &r2, &r3, &c, &ptr); > + info->fprintf_func(info->stream, "%-12s %s,%s,%s,%s,%s,%p", > + op_name, str_r(r0), str_r(r1), > + str_r(r2), str_r(r3), str_c(c), ptr); > + break; > + > + case INDEX_op_mulu2_i32: > + tci_args_rrrr(&tb_ptr, &r0, &r1, &r2, &r3); > + info->fprintf_func(info->stream, "%-12s %s,%s,%s,%s", > + op_name, str_r(r0), str_r(r1), > + str_r(r2), str_r(r3)); > + break; > + > + case INDEX_op_add2_i32: > + case INDEX_op_sub2_i32: > + tci_args_rrrrrr(&tb_ptr, &r0, &r1, &r2, &r3, &r4, &r5); > + info->fprintf_func(info->stream, "%-12s %s,%s,%s,%s,%s,%s", > + op_name, str_r(r0), str_r(r1), str_r(r2), > + str_r(r3), str_r(r4), str_r(r5)); > + break; > +#endif One single comment, I'd add one space after each comma in format arguments to make output less compact. Matter of taste probably. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>