Daniel P. Berrangé <berra...@redhat.com> writes:
> On Wed, Mar 17, 2021 at 01:44:05PM +0100, Thomas Huth wrote: >> On 17/03/2021 12.16, Peter Maydell wrote: >> > On Wed, 17 Mar 2021 at 11:09, Thomas Huth <th...@redhat.com> wrote: >> > > >> > > FreeBSD version 12.1 is out of service now, and the task in the >> > > Cirrus-CI is failing. Update to 12.2 to get it working again. >> > > Unfortunately, there is a bug in libtasn1 that triggers with the >> > > new version of Clang that is used there (see this thread for details: >> > > https://lists.gnu.org/archive/html/qemu-dove/2021-02/msg00739.html ), >> > > so we have to disable gnutls for now to make it work again. We can >> > > enable it later again once libtasn1 has been fixed in FreeBSD. >> > > >> > > Signed-off-by: Thomas Huth <th...@redhat.com> >> > >> > Is it feasible to make configure check for "is libtasn1 broken"? >> > I guess since it only shows up as "when you try to use it >> > it fails" that would be a runtime check rather than compile >> > time, which isn't really possible :-( >> >> I don't really have a clue about this crypto stuff... Daniel, Stefan, Roman, >> Christian, Eric ... you debugged the original problem on macOS, do you think >> it's possible to add a check for this libtasn1 problem to our "configure" >> (or meson.build file)? > > It is tricky because the flaw is not specific to the version of > tasn1, rather to the combination of tasn1 and the compiler used, > so there's no simple way to detect it statically from configure. > > If don't want the big hammer of disabling gnutls, perhaps adding > a flag to disable tasn1 would be simpler, as that would only > disable test suite, and no actual QEMU core functionality (which > is all working fine) I suspect we'll forget to remove this flag as well when the time comes. Without adding new things I think this patch would be fine with an additional comments: # --disable-gnutls until libtasn1 is fixed in FreeBSD (#ref?) > > Regards, > Daniel -- Alex Bennée