On 3/22/21 4:00 PM, Richard Henderson wrote: > On 3/22/21 4:03 AM, Philippe Mathieu-Daudé wrote: >>> - rc = qemu_mprotect_none(end, page_size); >> >> What about: >> >> #ifdef CONFIG_DARWIN >> >> /* ... */ >> (void)rc; >> #else >> >>> - g_assert(!rc); >> >> #endif > > What does that buy us, really? It seems like it just clutters the code > with ifdefs.
No problem.
