On Mon, Sep 12, 2011 at 3:47 PM, Devin Nakamura <devin...@gmail.com> wrote: /* See qed_find_cluster(), especially how request->l2_table reference count works */ > +int qed_find_cluster_sync(BDRVQEDState *s, QEDRequest *request, uint64_t pos, > + size_t len, uint64_t *offset, > + size_t *contiguous_bytes)
If you respin please add a comment like the one above. It's easy to forget that this function grabs the l2_table and gives you a reference. Let's put a warning in place. Stefan