On Wed, Mar 24, 2021 at 7:12 AM Mahmoud Mandour <ma.mando...@gmail.com> wrote: > > On Tue, Mar 23, 2021 at 4:15 PM Stefan Hajnoczi <stefa...@gmail.com> wrote: >> >> On Fri, Mar 19, 2021 at 03:25:27PM +0200, Mahmoud Mandour wrote: >> > @@ -588,7 +587,7 @@ out: >> > } >> > >> > pthread_mutex_destroy(&req->ch.lock); >> > - free(fbuf.mem); >> > + g_free(fbuf.mem); >> > free(req); >> >> ^--- was FVRequest allocation changed in a previous patch? >> Maybe an earlier patch forgot to use g_free() here. >> >> Aside from this: >> >> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > > I did not change the allocation of FVRequest. I believe that's why > this is left unchanged.
Okay, I see it's allocated by libvhost-user and not directly by virtiofsd code. Thanks, Stefan