On 3/24/21 11:29 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> move exception code out of tcg/ >> as we need part of it for KVM too. >> >> put the exception code into separate cpu modules as appropriate, >> including: >> >> cpu-sysemu.c >> tcg/tcg-cpu.c >> tcg/sysemu/tcg-cpu.c >> >> to avoid naming confusion with the existing cpu_tcg.c, >> containg cpu models definitions for 32bit TCG-only cpus, >> rename this file as tcg/tcg-cpu-models.c > > Obviously all of this should not be done in one step.
Ok will work on it. > > Isn't tcg/tcg-* redundant? I considered that, and at some point I had "cpu.c" for x86 too. After working on it for a while, I noticed how it got really confusing in practice to have files called just "cpu.c" when working on them, just too many files are called "cpu.c". It was confusing. I also like the extra emphasis on the accel for this: kvm/kvm.c kvm/kvm-cpu.c kvm/kvm-stub.c tcg/tcg-cpu.c tcg/tcg-stub.c Thanks, Claudio