On 3/25/21 8:03 PM, Richard Henderson wrote: > On 3/23/21 9:46 AM, Claudio Fontana wrote: >> +#define is_a64(env) (false) > ... >> +#define arm_el_is_aa64(env, el) (false) > > Why a define and not have the ifdef inside the static inline? > > This define is causing you to make other random changes to avoid unused > variables, and I'm not keen. > > If you're running into problems with --enable-debug not eliminating code > blocks, leading to link errors, then I think that > __attribute__((always_inline)) and a comment will be the best option.
I am not getting linking troubles even with --enable-debug atm, so I'd avoid the attribute for now? > > >> + >> +#endif /* TARGET_AARCH64 */ >> + >> +/** >> + * arm_hcr_el2_eff(): Return the effective value of HCR_EL2. >> + * E.g. when in secure state, fields in HCR_EL2 are suppressed, >> + * "for all purposes other than a direct read or write access of HCR_EL2." >> + * Not included here is HCR_RW. >> + */ >> +uint64_t arm_hcr_el2_eff(CPUARMState *env); > > Is this diff being weird or did you really move this declaration, and if so, > why? Yes, weird diff. > > > r~ > Tx
